Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] CRD sync handling #3941

Closed
jkroepke opened this issue Oct 27, 2023 · 3 comments · Fixed by #4065
Closed

[kube-prometheus-stack] CRD sync handling #3941

jkroepke opened this issue Oct 27, 2023 · 3 comments · Fixed by #4065

Comments

@jkroepke
Copy link
Member

jkroepke commented Oct 27, 2023

Actually, I totally forgot that there are more moving parts regarding this:

This is going to be lost next time we run a sync if we don't do the right process now. Asking for help regarding this process to @jkroepke 🙏

Originally posted by @GMartinez-Sisti in #3938 (comment)

@jkroepke
Copy link
Member Author

@GMartinez-Sisti I would propose to add an additional CI check for kube-prometheus-stack here to ensure CRDs are fine. Do you think that this is sufficent?

@GMartinez-Sisti
Copy link
Member

@GMartinez-Sisti I would propose to add an additional CI check for kube-prometheus-stack here to ensure CRDs are fine. Do you think that this is sufficent?

That works, it's better to flag it right on the PR and block it from being merged.

@jcpunk
Copy link
Contributor

jcpunk commented Nov 6, 2023

With 0.69.0 just released this ticket popped up on my reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants