Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken log-level for values other than debug. #560

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

Harkishen-Singh
Copy link
Contributor

@Harkishen-Singh Harkishen-Singh commented Jul 14, 2021

Signed-off-by: Harkishen Singh harkishensingh@hotmail.com

Fixes: #557

Signed-off-by: Harkishen Singh <harkishensingh@hotmail.com>
@sysadmind
Copy link
Contributor

I think the change to the new github.com/go-kit/kit/log was intentional from @roidelapluie. They may be able to help understand why the log levels are broken.

@Harkishen-Singh
Copy link
Contributor Author

@sysadmind the changes in this PR were inspired from node_exporter's way of implementing logging. That's how I got it fixed.

@roidelapluie
Copy link
Contributor

github.com/go-kit/log is the new one

Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evkuzin
Copy link

evkuzin commented Aug 2, 2021

@roidelapluie please approve or give an advice how to fix it another way. The whole journald is full of debug logs because of this bug.

Copy link

@deflinhec deflinhec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As go-kit#1173 mentioned

@carlpett
Copy link

Anyone in @prometheus-community/postgres_exporter have time to approve/merge this? There's a rather high overhead right now, with every scrape in default configuration logging roughly 1kb.

@rhollins
Copy link

would be great to have this merged

Copy link

@ppihus ppihus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done according to go-kit/kit#1173

@ppihus
Copy link

ppihus commented Dec 6, 2021

@SuperQ, could you please approve this? Due to high amount of logs for many db clusters, we're seeing a significant increase in our logging ingestion costs.

@FlxPeters
Copy link

Any news here? We face the same problem like @ppihus. Filter logs on ingest is possible but nasty.
Would be great if this can be fixed soon as it seams we have a solution :-)

@mindw
Copy link

mindw commented Jan 4, 2022

@wrouesnel , @SuperQ , we're seeing the same issue and had to downgrade to 0.9.x. Is there anything that can be done to move this one along?

@zawadaa
Copy link

zawadaa commented Jan 14, 2022

Looks like this project is abandond :-(

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for delay in reviewing.

@SuperQ
Copy link
Contributor

SuperQ commented Jan 14, 2022

Sorry, I've been very busy with things and have not had the time to keep up with work on this exporter. And I really should, since my $dayjob has a bunch of PG servers.

@SuperQ SuperQ merged commit 017e060 into prometheus-community:master Jan 14, 2022
SuperQ added a commit that referenced this pull request Jan 14, 2022
* [BUGFIX] Fix broken log-level for values other than debug. #560

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jan 14, 2022
SuperQ added a commit that referenced this pull request Jan 14, 2022
* [BUGFIX] Fix broken log-level for values other than debug. #560

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Jan 14, 2022
* [BUGFIX] Fix broken log-level for values other than debug. #560

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Jan 14, 2022
* [BUGFIX] Fix broken log-level for values other than debug. #560

Signed-off-by: SuperQ <superq@gmail.com>
@zawadaa
Copy link

zawadaa commented Jan 14, 2022

Work can be absorbing. ;-) It's good that everything is OK with your health.
I've build on my laptop - works like a charm :-)

angaz pushed a commit to angaz/postgres_exporter that referenced this pull request Mar 3, 2022
* [BUGFIX] Fix broken log-level for values other than debug. prometheus-community#560

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: Angus Dippenaar <angusdippenaar@gmail.com>
angaz pushed a commit to angaz/postgres_exporter that referenced this pull request Mar 3, 2022
* [BUGFIX] Fix broken log-level for values other than debug. prometheus-community#560

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: Angus Dippenaar <angusdippenaar@gmail.com>
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
…log-level

Fix broken log-level for values other than debug.
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
* [BUGFIX] Fix broken log-level for values other than debug. prometheus-community#560

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--log.level has no effect