adding codified functionality for logical replication metrics #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zachary Caldarola <zachary.caldarola@reddit.com>
sheldor14
force-pushed
the
replication_slot
branch
from
a4e0f16
to
3007500
Compare
|
cc @SuperQ |
SuperQ
requested changes
Jan 25, 2023
collector/pg_replication_slots.go
Outdated
| ) | ||
|
|
||
| func init() { | ||
| registerCollector("replication_slot", defaultEnabled, NewPGReplicationSlotCollector) |
There was a problem hiding this comment.
I just realized we were drifting from the naming conventions here. This is patterned after the node_exporter, where we make sure collectors are named based on the files. So the filename should be replication_slot.go.
But I'm also somewhat fine with pg_<collector>.go.
What do you think @sysadmind?
There was a problem hiding this comment.
I don't know that I have a strong opinion here. The tables inside the database have the pg_ prefix, so I could argue keeping the prefix. I'm not opposed to either direction.
There was a problem hiding this comment.
Since this is local to the package, I think we should name them after the collector to keep with the convention. pg_ seems redundant.
Signed-off-by: Zachary Caldarola <zachary.caldarola@reddit.com>
sysadmind
requested changes
Jan 25, 2023
|
Ping @sysadmind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given the push to codify some of the queries.yaml statements, we want to add logical replication metrics. This metric will be labeled on the slot name and the metric will be the distance between the
current_wal_lsn()and the confirmed_flush_lsn