Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replication collector #854

Merged
merged 1 commit into from Jul 3, 2023
Merged

Fix replication collector #854

merged 1 commit into from Jul 3, 2023

Conversation

tomhughes
Copy link
Contributor

Make NewPGReplicationCollector actually construct a replication collector, not a postmaster collector.

@tomhughes
Fix replication collector
d920553 
Signed-off-by: Tom Hughes <tom@compton.nu>
sysadmind
sysadmind approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

@sysadmind sysadmind merged commit d01184f into prometheus-community:master Jul 3, 2023
10 checks passed
@tomhughes tomhughes deleted the replication branch July 3, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysadmind sysadmind sysadmind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomhughes @sysadmind