Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Probe/Packet Timeout Option #19

Open
s00500 opened this issue Jan 23, 2023 · 5 comments
Open

Per Probe/Packet Timeout Option #19

s00500 opened this issue Jan 23, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@s00500
Copy link

s00500 commented Jan 23, 2023

On go-ping this PR existed:

go-ping/ping#202

It would be very usefull to have a packet timeout option on the Pinger in this package

@SuperQ SuperQ changed the title Packet Timeout Option Per Probe/Packet Timeout Option Jan 23, 2023
@SuperQ
Copy link
Contributor

SuperQ commented Jan 23, 2023

Yup! Absolutely something we want to implement.

@SuperQ SuperQ added the enhancement New feature or request label Jan 23, 2023
@TheRushingWookie
Copy link
Contributor

Hi! I'm interesting in either implementing this or rebasing https://github.com/go-ping/ping/pull/202/files into pro-bing.

Which way would you guys prefer?

@SuperQ
Copy link
Contributor

SuperQ commented Apr 4, 2023

It would need to fix the implementation issues of the original PR. As pointed out in several PRs to do per-packet timeouts, it needs to use a Go timer callback to accurately handle the timeouts, as well as not constantly sweep the packet tracking data.

I started working on refactoring the packet tracking in #9. The intention was to make it easier to implement the per-packet timeouts.

@TheRushingWookie
Copy link
Contributor

I'll take a look at #9 and go-ping/ping#202

I think using a Go timer makes sense, though I'm not sure how expensive it is. I'll take a look at the implementation to make sure its cheap.

@eysa12123
Copy link

Yup! Absolutely something we want to implement.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants