Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Cannot run more than one wal.LiveReader with metrics #646

Closed
csmarchbanks opened this issue Jul 2, 2019 · 0 comments · Fixed by #649
Closed

Cannot run more than one wal.LiveReader with metrics #646

csmarchbanks opened this issue Jul 2, 2019 · 0 comments · Fixed by #649

Comments

@csmarchbanks
Copy link
Contributor

csmarchbanks commented Jul 2, 2019

#619 changed the LiveReader to take a prometheus registerer instead of always using the default registerer. However, now if you try to instantiate more than one LiveReader with the same registerer it will panic.

You can pass nil as the registerer to avoid the panic but that means that metric will no longer show up.

cc: @brancz since I think you are doing the Prometheus release soon. This was breaking Prometheus when I tried to update prometheus/prometheus#5592 in preparation for 2.11.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant