Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASP.NET package targetting netcoreapp3.0 #164

Closed
kerams opened this issue Oct 26, 2019 · 3 comments
Closed

ASP.NET package targetting netcoreapp3.0 #164

kerams opened this issue Oct 26, 2019 · 3 comments

Comments

@kerams
Copy link

kerams commented Oct 26, 2019 •
edited

Hey, would you be OK with creating a netcoreapp3.0 target for Prometheus.AspNetCore? Right now, when I reference the package in a ASP.NET core 3 project, the Microsoft.AspNetCore dependency brings a lot of baggage that pollutes the lock file, even though it's redundant for that particular target. I could send in a PR, it should only be a couple of lines.
@josephwoodward josephwoodward mentioned this issue Nov 29, 2019
Merged
@sandersaares
Copy link
Member

Sure thing, will be published in next version. Thanks @kerams and @josephwoodward for taking action on this!

@giggio
Copy link

giggio commented Jun 24, 2020

Was this ever fixed? I just noticed that 3.0 or 3.1 are still not there.

image

@giggio
Copy link

giggio commented Jun 24, 2020

Nevermind, I was not looking at the ASPNET Nuget. It is there. Sorry about that. https://www.nuget.org/packages/prometheus-net.AspNetCore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giggio @kerams @sandersaares