Set Read/ReadHeaderTimeouts on http.Server #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoBraveCoding
approved these changes
Feb 14, 2023
|
I am not convinced about this change if I am honest, particularly the hardcoded nature of the value. Perhaps making them configurable might make sense but my gut feeling tells me that this could/should be mitigated at ingress/proxy layer if required. The client here is expected to be Kubernetes itself. |
There was a problem hiding this comment.
From what I can tell, the timeout for webhook configurations has to be between 1 second and 30 seconds, with a default of 10s for v1 (ref). I'd be ok with a hardcoded timeout value of 30s so we don't introduce a potentially breaking change.
In addition we should evaluate if there's value in enabling the gosec linter. My first impression is that it's a bit noisy but I haven't looked very deep.
Default to 30s via gosec linter - G112: Potential slowloris attack https://medium.com/a-journey-with-go/go-understand-and-mitigate-slowloris-attack-711c1b1403f6 Signed-off-by: Manuel Rüger <manuel@rueg.eu>
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
via gosec linter - G112: Potential slowloris attack
https://medium.com/a-journey-with-go/go-understand-and-mitigate-slowloris-attack-711c1b1403f6
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.