config-reloader: add init-config-reloader to alertmanager #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures there is no race between alertmanager and config-reloader generating config during initial launch Fixes prometheus-operator#5357
simonpasquier
approved these changes
Feb 21, 2023
| operator.LogLevel(a.Spec.LogLevel), | ||
| operator.WatchedDirectories(watchedDirectories), | ||
| operator.VolumeMounts(configReloaderVolumeMounts), | ||
| operator.Shard(-1), |
There was a problem hiding this comment.
This isn't needed for Alertmanager but I see that you've copied it from the existing reloader config container so it can be cleaned up in a following PR as well.
Suggested change
| operator.Shard(-1), |
There was a problem hiding this comment.
Yeah, thought about that. Just wanted to keep as close to the sidecar reloader config as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reuses the same approach used for prometheus statefulset that adds
init-config-reloaderinitContainer to alertmanager statefulset - #3955.Effectively
init-config-reloaderwill pregenerate the alertmanager config soalertmanagerwon't fail due to missing config.Fixes #5357
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.