Add OpsGenieAPIURL OpsGenieAPIKey to global config #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why e2e is failing? |
|
Failed CI might have been a flake, unfortunately, I don't have permissions to re-run it |
simonpasquier
approved these changes
Mar 20, 2023
|
not merged yet? |
|
Thanks! |
sthaha
added a commit
to sthaha/prometheus-operator
that referenced
this pull request
Jun 19, 2023
This commit partially address prometheus-operator#5422 by refactoring server and agent operator code that updates the prometheus config secrets. It moves the common functionalities to pkg/prometheus (prompkg). The refactor adds the following functions Store Related * AddRemoteWritesToStore * AddRemoteReadToStore * AddAPIServerConfigToStore Operator Related * MakeCompressedSecretForPrometheus GH: prometheus-operator#5455 Signed-off-by: Sunil Thaha <sthaha@redhat.com>
5 tasks
sthaha
added a commit
to sthaha/prometheus-operator
that referenced
this pull request
Jun 19, 2023
This commit partially address prometheus-operator#5422 by refactoring server and agent operator code that updates the prometheus config secrets. It moves the common functionalities to pkg/prometheus (prompkg). The refactor adds the following functions Store Related * AddRemoteWritesToStore * AddRemoteReadToStore * AddAPIServerConfigToStore Operator Related * MakeCompressedSecretForPrometheus GH: prometheus-operator#5455 Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
This PR add support for OpsGenieAPIKey/OpsGenieAPIURL in the global config
This will Add:
spec.alertmanagerConfiguration.global.opsGenieApiUrspec.alertmanagerConfiguration.global.opsGenieApiKeyType of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.
cc @simonpasquier