pkg/thanos: use metadata-informer for configmaps #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow up of fix of prometheus-operator#5410. The patch updates thanos controllers as well to use metadata-informer for watching configmaps. Fixes: prometheus-operator#5438 Signed-off-by: Sunil Thaha <sthaha@redhat.com>
|
Not sure if this shouldn't be considered an ENHANCEMENT since it improves functionality vs fixing anything 🤔 |
simonpasquier
added a commit
to simonpasquier/prometheus-operator
that referenced
this pull request
Oct 9, 2023
The Prometheus agent controller didn't use the metadata informer for secrets and configmaps as implemented in prometheus-operator#5424 and prometheus-operator#5448 for the other controllers. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
5 tasks
simonpasquier
added a commit
to simonpasquier/prometheus-operator
that referenced
this pull request
Oct 10, 2023
The Prometheus agent controller didn't use the metadata informer for secrets and configmaps as implemented in prometheus-operator#5424 and prometheus-operator#5448 for the other controllers. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
added a commit
to simonpasquier/prometheus-operator
that referenced
this pull request
Oct 10, 2023
The Prometheus agent controller didn't use the metadata informer for secrets and configmaps as implemented in prometheus-operator#5424 and prometheus-operator#5448 for the other controllers. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
added a commit
to simonpasquier/prometheus-operator
that referenced
this pull request
Oct 10, 2023
The Prometheus agent controller didn't use the metadata informer for secrets and configmaps as implemented in prometheus-operator#5424 and prometheus-operator#5448 for the other controllers. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
added a commit
to simonpasquier/prometheus-operator
that referenced
this pull request
Oct 10, 2023
The Prometheus agent controller didn't use the metadata informer for secrets and configmaps as implemented in prometheus-operator#5424 and prometheus-operator#5448 for the other controllers. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is follow up of fix for #5410. The patch updates thanos controllers as well to use metadata-informer for watching configmaps.
Fixes: #5438
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)