feat: add bot_token_file in TelegramConfig #5882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating validations as well, would be ready for review after that |
slashpai
force-pushed
the
bot_token_file
branch
from
1ece404
to
f172ede
Compare
telegramConfigs validation was missing in v1beta. I added it in this PR |
5 tasks
HaveFun83
pushed a commit
to HaveFun83/prometheus-operator
that referenced
this pull request
Sep 4, 2023
The telegram bot_token_file is already handle in prometheus-operator#5882
slashpai
force-pushed
the
bot_token_file
branch
from
f172ede
to
77ae7d0
Compare
|
@simonpasquier addressed comments |
slashpai
force-pushed
the
bot_token_file
branch
from
77ae7d0
to
49e9147
Compare
slashpai
force-pushed
the
bot_token_file
branch
from
49e9147
to
95e6d8e
Compare
|
Unit tests are complaining :) |
slashpai
force-pushed
the
bot_token_file
branch
from
95e6d8e
to
ea78824
Compare
fixed :) |
|
Is this good to merge? :) |
Merged
ArthurSens
reviewed
Sep 6, 2023
Fixes prometheus-operator#5858 Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai
force-pushed
the
bot_token_file
branch
from
ea78824
to
a5f4f73
Compare
|
@ArthurSens Please take a look again :) |
ArthurSens
approved these changes
Sep 7, 2023
simonpasquier
pushed a commit
that referenced
this pull request
Sep 11, 2023
* alertmanager: add missing types alertmanager v0.26 introduced some new types in receiver configuration Fixes #5857 * pkg/alertmanager: add BotTokenFile to telegramConfig alertmanager v0.26 introduced some new types in receiver configuration * pkg/alertmanager: add input sanitize and unit test add input sanitize and unit test for new alertmanager types Telegram: bot_token_file Webhook: url_file Pushover: user_key_file and token_file fix: #5857 * fix format * pkg/alertmanger: remove changes for telegram bot_toke_file The telegram bot_token_file is already handle in #5882 * pkg/alertmanager: revert name change in telegramconfig --------- Co-authored-by: Hendrik Ferber <ferber@synyx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5858
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.