replace UpdateStatus() for ApplyStatus ThanosRuler #5913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
| WithUnavailableReplicas(a.Status.UnavailableReplicas) | ||
|
|
||
| for _, condition := range a.Status.Conditions { | ||
| trac.WithConditions( |
There was a problem hiding this comment.
(suggestion) this can be extracted to pkg/operator/operator.go (or a new pkg/operator/applyconfiguration.go) and shared with Alertmanager.
inline func PrometheusOperatorFieldManager in operator pkg delete duplicate line Signed-off-by: Mario Fernandez <mariofer@redhat.com>
simonpasquier
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To set the status subresource, the operator make use of ApplyStatus() instead of UpdateStatus() to avoid informer errors.
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry