fix: detect changes without list/watch perms on namespaces #5934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements a poll-based namespace lister/watcher when the operator's service account isn't granted the list & watch permissions on all namespaces. Instead of sending a watch request, the controller will get every configured namespace every 15 seconds and sends the expected watch events when a namespace is added/updated/deleted. It still requires the service account to be granted the get permission on the configured namespaces. Closes prometheus-operator#3847 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
ArthurSens
approved these changes
Sep 21, 2023
|
Thanks for splitting this up, this one was a lot easier to review :) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change implements a poll-based namespace lister/watcher when the operator's service account isn't granted the list & watch permissions on all namespaces. Instead of sending a watch request, the controller will get every configured namespace every 15 seconds and sends the expected watch events when a namespace is added/updated/deleted.
It still requires the service account to be granted the get permission on the configured namespaces.
Closes #3847
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.