fix: add --cluster.label to alertmanager #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
small nit: this is more a bug fix for me since it can avoid an Alertmanager pod from joining another cluster than expected. |
|
i've found a few references in the Alertmanager issues: |
slashpai
force-pushed
the
am_clusterlabel
branch
from
9f65dbd
to
a2b43ed
Compare
|
@simonpasquier addressed comments |
slashpai
changed the title
If multiple Alertmanager clusters are deployed on the same cluster, it can happen that because pod IP addresses are recycled, an Alertmanager instance from cluster B connects with cluster A. --cluster.label flag was introduced in alertmanager v0.26, this helps to block any traffic that is not meant for the cluster. The value is hardcoded and the value is guaranteed to be unique in a given cluster but if there's a use case, we can consider a new field in the CRD. This commit sets default --cluster.label flag as namespace/name when Alertmanager version used is >= v0.26 Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai
force-pushed
the
am_clusterlabel
branch
from
a2b43ed
to
f143e68
Compare
|
@simonpasquier updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple Alertmanager clusters are deployed on the same cluster, it can happen
that because pod IP addresses are recycled, an Alertmanager instance from cluster B
connects with cluster A.
--cluster.labelflag was introduced in alertmanagerv0.26, this helps to blockany traffic that is not meant for the cluster.
The value is hardcoded and the value is guaranteed to be unique in a given cluster but
if there's a use case, we can consider a new field in the CRD.
This commit sets default
--cluster.labelflag as namespace/namewhen Alertmanager version used is >= v0.26
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.