fix: update reloader requests and limits when updated #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add tests for this. |
simonpasquier
force-pushed
the
fix-5970
branch
from
3c60fdf
to
375f078
Compare
simonpasquier
force-pushed
the
fix-5970
branch
5 times, most recently
from
6a4b055
to
a9e1271
Compare
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
fix-5970
branch
from
a9e1271
to
f618c5b
Compare
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
fix-5970
branch
from
f618c5b
to
a33cb4c
Compare
ArthurSens
approved these changes
Oct 19, 2023
Comment on lines
+75
to
+80
| // The struct tag are needed for github.com/mitchellh/hashstructure to take | ||
| // the field values into account when generating the statefulset hash. | ||
| CPURequests Quantity `hash:"string"` | ||
| CPULimits Quantity `hash:"string"` | ||
| MemoryRequests Quantity `hash:"string"` | ||
| MemoryLimits Quantity `hash:"string"` |
Comment on lines
+198
to
+208
| type PrometheusOperatorOpts struct { | ||
| Namespace string | ||
| AllowedNamespaces []string | ||
| DeniedNamespaces []string | ||
| PrometheusNamespaces []string | ||
| AlertmanagerNamespaces []string | ||
| EnableAdmissionWebhook bool | ||
| ClusterRoleBindings bool | ||
| EnableScrapeConfigs bool | ||
| AdditionalArgs []string | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5970
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.