Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for configuring STS persistentVolumeClaimRetentionPolicy #6038

Conversation

adinhodovic
Copy link
Contributor

@adinhodovic adinhodovic commented Oct 25, 2023

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Allows configuring a Statefulsets persistentVolumeClaimRetentionPolicy which will allow for easier statefulset cleanups on deletion.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

feat: Add `persistentVolumeClaimRetentionPolicy` field to the Prometheus and PrometheusAgent CRDs.

@adinhodovic adinhodovic requested a review from a team as a code owner October 25, 2023 10:59
@adinhodovic adinhodovic force-pushed the persistent-volume-claim-retention-policy branch from a53b2b7 to 2b567bb Compare October 25, 2023 10:59
…olicy

Signed-off-by: adinhodovic <hodovicadin@gmail.com>
@adinhodovic adinhodovic force-pushed the persistent-volume-claim-retention-policy branch from 2b567bb to 9e8a160 Compare October 25, 2023 11:10
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ArthurSens ArthurSens merged commit c0f9cef into prometheus-operator:main Nov 14, 2023
17 checks passed
@ArthurSens ArthurSens mentioned this pull request Nov 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants