feat: support Selectors field in kubernetes SD #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashpai
force-pushed
the
node-discovery
branch
from
0d639a5
to
2d7874f
Compare
4 tasks
| Role string `json:"role"` | ||
| Role K8SRole `json:"role"` | ||
| // Selector to select objects. | ||
| Selectors []K8SSelectorConfig `json:"selectors,omitempty"` |
There was a problem hiding this comment.
there can be only one item in the list for the same role.
Suggested change
| Selectors []K8SSelectorConfig `json:"selectors,omitempty"` | |
| // +optional | |
| // +listType=map | |
| // +listMapKey=role | |
| Selectors []K8SSelectorConfig `json:"selectors,omitempty"` |
There was a problem hiding this comment.
@simonpasquier do we want to specify a default here since selectors is not required field?
main_test.go:184: initialize ScrapeConfig v1alpha1 CRD: create CRD scrapeconfigs on the apiserver: create CRD ScrapeConfig: CustomResourceDefinition.apiextensions.k8s.io "scrapeconfigs.monitoring.coreos.com" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[kubernetesSDConfigs].items.properties[selectors].items.properties[role].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
2d7874f
to
d8c31d2
Compare
slashpai
force-pushed
the
node-discovery
branch
from
d8c31d2
to
1c3d873
Compare
|
@simonpasquier addressed review comments |
slashpai
force-pushed
the
node-discovery
branch
2 times, most recently
from
9854ef8
to
b82ed76
Compare
slashpai
force-pushed
the
node-discovery
branch
from
b82ed76
to
f0ce96a
Compare
Related-to prometheus-operator#5711 Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai
force-pushed
the
node-discovery
branch
from
f0ce96a
to
c2fe7a8
Compare
|
@simonpasquier addressed the issue. Could you please review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-to #5711
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
feat: support Selectors field in kubernetes SD
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.