Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logs to os.Stdout #6085

Merged

Conversation

perylemke
Copy link
Contributor

Description

According #6035 it's necessary change to os.Stdout instead os.Stderr and change fmt.Print* to level in logs.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


Changed all stderr logs to stdout and include levels too
@perylemke perylemke requested a review from a team as a code owner November 14, 2023 11:13
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great already! I noticed that you missed one in pkg/prometheus/promcfg_test.go.

I think that what we really cared about was the ones in cmd/config-reloader/main.go, but if we're making changes to tests as well, let's algo change the one you missed :)

Changed on line 70 to os.Stdout
@perylemke
Copy link
Contributor Author

@ArthurSens

I changed on pkg/prometheus/promcfg_test.go too ;)

@ArthurSens
Copy link
Member

Thankssss

@ArthurSens ArthurSens enabled auto-merge (squash) November 14, 2023 13:36
@ArthurSens ArthurSens changed the title [WIP] Change logs to os.Stdout Change logs to os.Stdout Nov 14, 2023
@ArthurSens ArthurSens merged commit 3930fad into prometheus-operator:main Nov 14, 2023
17 checks passed
@rexagod
Copy link
Contributor

rexagod commented Nov 14, 2023

Ah, it seems I'm a tad late here. Thank you for your contribution, @perylemke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants