fix: convert consul scheme to lowercase while setting prometheus config

[slashpai]

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Noticed while playing around ConsulSD config Scheme should be converted to lowercase to fix error unsupported protocol scheme \"HTTPS\"" from Prometheus

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

• CHANGE (fix or feature that would cause existing functionality to not work as expected)
• FEATURE (non-breaking change which adds functionality)
• BUGFIX (non-breaking change which fixes an issue)
• ENHANCEMENT (non-breaking change which improves existing functionality)
• NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

fix: convert consul scheme to lowercase while setting prometheus config

[simonpasquier]

There are a couple more places where we can do the same I believe.

[slashpai]

There are a couple more places where we can do the same I believe.

The one on ScrapeConfigSpec is already taken care

prometheus-operator/pkg/prometheus/promcfg.go

Lines 2284 to 2286 in b6610bb

	if sc.Spec.Scheme != nil {
	cfg = append(cfg, yaml.MapItem{Key: "scheme", Value: strings.ToLower(*sc.Spec.Scheme)})
	}

I don't see scheme used in other ScrapeConfigs

[simonpasquier]

prometheus-operator/pkg/prometheus/promcfg.go

Lines 716 to 718 in b6610bb

	if ep.Scheme != "" {
	cfg = append(cfg, yaml.MapItem{Key: "scheme", Value: ep.Scheme})
	}

prometheus-operator/pkg/prometheus/promcfg.go

Lines 927 to 929 in b6610bb

	if m.Spec.ProberSpec.Scheme != "" {
	cfg = append(cfg, yaml.MapItem{Key: "scheme", Value: m.Spec.ProberSpec.Scheme})
	}

prometheus-operator/pkg/prometheus/promcfg.go

Lines 1180 to 1182 in b6610bb

	if ep.Scheme != "" {
	cfg = append(cfg, yaml.MapItem{Key: "scheme", Value: ep.Scheme})
	}

prometheus-operator/pkg/prometheus/promcfg.go

Lines 1582 to 1585 in b6610bb

	cfg := yaml.MapSlice{
	{Key: "path_prefix", Value: am.PathPrefix},
	{Key: "scheme", Value: am.Scheme},
	}

[slashpai]

I was looking in ScrapeConfig CRD :)

For others some doesn't have validation api level and some are using http/https.
Do we want to update api checks as well?

[simonpasquier]

My bad!