Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Configuration #82

Closed
lswith opened this issue Nov 28, 2016 · 8 comments
Closed

Static Configuration #82

lswith opened this issue Nov 28, 2016 · 8 comments
Labels

Comments

@lswith
Copy link

lswith commented Nov 28, 2016

I would like to have the blackbox_exporter support static configuration. This means that the configuration such as:

  • target
  • period
  • module + target combination

can be specified in the configuration file and the blackbox_exporter will add labels to the metrics and scrape the combinations periodically. This could be exposed over a /metrics endpoint alongside the /probe endpoint already exposed.

The reason for this feature is mainly to avoid complex and specific relabelling configuration in prometheus. Also, for our use case, the relabelling doesn't easily work when the blackbox_exporter is exposed as a service over consul.

@brian-brazil
Copy link
Contributor

This is not the intended architecture of a Prometheus exporter. Scheduling and service discovery belong with Prometheus, not exporters.

You should run the blackbox exporter beside Prometheus.

@lswith
Copy link
Author

lswith commented Nov 28, 2016

This would simply be an additional feature alongside the current feature set.

@lswith
Copy link
Author

lswith commented Nov 28, 2016

Are all exporters intended to run alongside prometheus? Why is the blackbox-exporter a special case?

@lswith lswith changed the title Change to Static Configuration Static Configuration Nov 28, 2016
@brian-brazil
Copy link
Contributor

What you request is an explicit non-goal of this exporter.

Are all exporters intended to run alongside prometheus? Why is the blackbox-exporter a special case?

There's very few exporters in this category, currently only SNMP also fits. It's that way as it's impossible to run an exporter on something like a VIP.

@lswith
Copy link
Author

lswith commented Nov 28, 2016

Why can't the blackbox-exporter have its own explicit service discovery? It would allow it to be even more decoupled from Prometheus which I'm sure was the intent of making it a exporter in the first place.

@brian-brazil
Copy link
Contributor

Why can't the blackbox-exporter have its own explicit service discovery?

That is explicitly not the responsibility of an exporter. It's Prometheus's responsibility.

@lswith
Copy link
Author

lswith commented Nov 28, 2016

It just seems odd that we have extremely specific modules for very specific endpoints, and then pass in dynamic target configuration.

@brian-brazil
Copy link
Contributor

That doesn't seem odd to me. You'll want to probe potentially thousands of targets with the same sort of probe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants