Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move collectors to different package (v2) #1030

Closed
bwplotka opened this issue Apr 12, 2022 · 2 comments
Closed

Move collectors to different package (v2) #1030

bwplotka opened this issue Apr 12, 2022 · 2 comments

Comments

@bwplotka
Copy link
Member

bwplotka commented Apr 12, 2022

Reason:

  • Concise and focused package, clear boundaries and ability to extend options (currently there is no way to add more options to collector WITHOUT creating more deprecated code).

We can't do it in v1, because we would need to break compatibility. Something for v2.

image

Attempt: https://github.com/prometheus/client_golang/tree/movegocollector

@stale
Copy link

stale bot commented Oct 16, 2022

Hello 👋 Looks like there was no activity on this issue for the last 3 months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next 4 weeks, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the stale label Oct 16, 2022
@stale
Copy link

stale bot commented Jan 21, 2023

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant