Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace github.com/golang/protobuf with google protobuf #1277

Open
ahrycej opened this issue May 23, 2023 · 3 comments
Open

replace github.com/golang/protobuf with google protobuf #1277

ahrycej opened this issue May 23, 2023 · 3 comments

Comments

@ahrycej
Copy link

ahrycej commented May 23, 2023

Replace the github.com/golang/protobuf-1.5.3 with google code

The whole project seem to be depricated and it is recommended to go for google
from
https://github.com/golang/protobuf

"It has been superseded by the google.golang.org/protobuf module, which contains an updated and simplified API, support for protobuf reflection, and many other improvements. We recommend that new code use the google.golang.org/protobuf module.

Versions v1.4 and later of github.com/golang/protobuf are implemented in terms of google.golang.org/protobuf. Programs which use both modules must use at least version v1.4 of this one."

@edoger
Copy link

edoger commented Jun 5, 2023

To solve this problem, you need to start from github.com/prometheus/common, the ultimate reason is that github.com/prometheus/common depends on github.com/matttproud/golang_protobuf_extensions (very old and out of date).

@rufreakde
Copy link

Linking issue: prometheus/common#317

@pavelpatrin
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants