Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: superfluous response.WriteHeader #730

Closed
fcddk opened this issue Mar 25, 2020 · 4 comments
Closed

http: superfluous response.WriteHeader #730

fcddk opened this issue Mar 25, 2020 · 4 comments

Comments

@fcddk
Copy link

fcddk commented Mar 25, 2020

my code:
http.Handle(*metricsPath, promhttp.Handler())

logs:
<30>2020-03-25T16:42:46.704128+08:00 cmp001 libvirt-qemu-exporter[21928]: 2020/03/25 16:42:46 http: superfluous response.WriteHeader call from libvirt-qemu-exporter/vendor/github.com/prometheus/client_golang/prometheus/promhttp.(*responseWriterDelegator).WriteHeader (delegator.go:58)
<30>2020-03-25T16:42:46.704923+08:00 cmp001 libvirt-qemu-exporter[21928]: 2020/03/25 16:42:46 http: superfluous response.WriteHeader call from exporter/vendor/github.com/prometheus/client_golang/prometheus/promhttp.(*responseWriterDelegator).WriteHeader (delegator.go:58)

@fcddk
Copy link
Author

fcddk commented Mar 25, 2020

version v1.12.1

@beorn7
Copy link
Member

beorn7 commented Mar 26, 2020

v1.12.1

This repository currently only goes up to v1.5.1. Could you doublecheck which version you are using?

@fcddk
Copy link
Author

fcddk commented Mar 27, 2020

I'm sorry, version: 1.2.1.

@beorn7
Copy link
Member

beorn7 commented Mar 27, 2020

Then this is probably a dupe of #672, fixed in v1.5.1. Please upgrade. If the problem still occurs, please follow up here, and I'll re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants