Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeinfoResult.StartTime should be a time.Time #776

Closed
mxey opened this issue Jun 24, 2020 · 2 comments · Fixed by #777
Closed

RuntimeinfoResult.StartTime should be a time.Time #776

mxey opened this issue Jun 24, 2020 · 2 comments · Fixed by #777
Labels
enhancement help wanted low hanging fruit

Comments

@mxey
Copy link
Contributor

mxey commented Jun 24, 2020

Observed on release v1.7.1

RuntimeinfoResult.StartTime is a string containing a timestamp. If the field was a time.Time, Go's encoding/json would automatically parse the timestamp while unmarshalling.
@bwplotka
Copy link
Member

hm, yes I think we could change this (if compatibility allows ;p @beorn7)

Help wanted!

@beorn7
Copy link
Member

beorn7 commented Jun 24, 2020

No compatibility guarantees for the API client, anyway. So please go ahead and create a PR. (o:

@mxey mxey mentioned this issue Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use time.Time for timestamps in Runtimeinfo babiel/client_golang
3 participants
@mxey @beorn7 @bwplotka