Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a suitable deprecation notice #37

Closed
beorn7 opened this issue Nov 25, 2019 · 4 comments · Fixed by #38
Closed

Add a suitable deprecation notice #37

beorn7 opened this issue Nov 25, 2019 · 4 comments · Fixed by #38
Assignees

Comments

@beorn7
Copy link
Member

beorn7 commented Nov 25, 2019

This repo is essentially only used (within the Prometheus project) by prometheus/client_golang. There might be external users, of course, but prometheus/prometheus doesn't consume protobufs anymore since v2.0.0. This should be noted prominently in the README.md.

@beorn7 beorn7 self-assigned this Nov 25, 2019
@brian-brazil
Copy link
Contributor

Maybe we could remove all bar the Go uses? We can always add things back in as needed if that ends up making sense OM wise.

@beorn7
Copy link
Member Author

beorn7 commented Nov 26, 2019

I'll give it a spin.

@brian-brazil
Copy link
Contributor

Though thinking on it for OM we'd probably end up with the protos over in the OpenObservability org for all the languages, but that's not something that we've talked about.

@beorn7
Copy link
Member Author

beorn7 commented Nov 26, 2019

I would also expect the OM proto definitions to live somewhere else. This repo will most likely get graveyarded eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants