Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Metrics are incomplete if error encountered parsing CSV from HAProxy #77

Closed
beorn7 opened this issue Jun 22, 2017 · 1 comment
Closed
Labels

Comments

@beorn7
Copy link
Member

beorn7 commented Jun 22, 2017

This error could possibly even include a timeout, in which case we would prefer to not expose any metrics at all rather than an incomplete set (which can lead to heavy underreporting of traffic and thus cause false alerts). Essentially, in the scrape() method, we loop through the lines, setting metrics, and we will just skip errors there.

This will probably implicitly change/get fixed by moving to const metrics, see #43

@grobie grobie added the bug label Jul 20, 2017
@matthiasr
Copy link
Contributor

Fixed in #139!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants