Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release an up-to-date jar and one for java 6 #592

Closed
bliof-fc opened this issue Mar 22, 2021 · 11 comments
Closed

Release an up-to-date jar and one for java 6 #592

bliof-fc opened this issue Mar 22, 2021 · 11 comments

Comments

@bliof-fc
Copy link

bliof-fc commented Mar 22, 2021

Follow-up of #584 (comment)

How about releasing a dedicated jar for java 6? e.g.

The problem we are having is that we do security scans on our docker images and have processes to force people to fix their issues. And we have to log exceptions and keep explaining that this is not really a vulnerability.

The main benefit of fixing this is that you'll reduce the amount of communication in random other companies :D and this may be masking a real problem in the actual jars of people.

We are currently using 0.14.0 🤷 because 0.15.0 gets flagged.

ps. Happy to help with something of the sort but I am not very familiar with the java world.

fyi @fstab @brian-brazil (I've extracted the question in this issue)

@bliof-fc bliof-fc changed the title Release and up-to-date jar and one for java 6 Release an up-to-date jar and one for java 6 Mar 25, 2021
@bliof-fc
Copy link
Author

bliof-fc commented Apr 7, 2021

@fstab 👀 What do you think about this one?

@fstab
Copy link
Member

fstab commented Apr 7, 2021

Thanks a lot for the suggestion, and sorry for the delay. I will do this. Just to be clear: There is no security risk, because the CVE is just about parsing YAML from untrusted sources, and not about parsing your own config files. However, I understand that it's annoying to be flagged in security scans, so I will release two versions as suggested above.

As a first step, I created a feature branch for testing the agent with different Java versions (https://github.com/prometheus/jmx_exporter/tree/integration-test). I would like to create automated tests for both the jdk6 version and the jdk8 version, because it will be error prone to check manually if Java 6 still works. Once automated integration tests for both versions are in place, I will create a release.

@Boojapho
Copy link

Boojapho commented Jun 3, 2021

Thanks @fstab. This will definitely help.

Out of curiosity, why still support Java 6 since Oracle dropped extended support in 2016?

@fstab
Copy link
Member

fstab commented Jun 4, 2021

There are still users who have to operate legacy Java 6 applications, and Azul offer paid support for Java 6 until December 2023 (https://en.wikipedia.org/wiki/Java_version_history).

@Boojapho
Copy link

@fstab Were you able to make any progress on the integration tests?

@fstab
Copy link
Member

fstab commented Jun 29, 2021

Sorry for the delay. I picked it up again today and I'll do my best to finish it soon.

@fstab
Copy link
Member

fstab commented Jul 1, 2021

I merged it to master. I still need to verify the build and update documentation, but if all goes well I might be able to release this over the weekend.

@fstab
Copy link
Member

fstab commented Jul 4, 2021

done https://github.com/prometheus/jmx_exporter/releases/tag/parent-0.16.0

@Boojapho
Copy link

Outstanding @fstab. I really appreciate the work you put in to get this working! 🥇

@bliof-fc
Copy link
Author

👍 I've tried 0.16.1 with couple of our apps and it works as expected. Thanks a lot for the change 🙇

@beltran-rubo
Copy link

The collector (and the jmx_prometheus_httpserver) still has a reference to 1.23 at

<version>1.23</version> <!-- required for the Java 6 release -->
do you plan to address for the 'httpserver' jar file as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants