Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal MySQL version to Scraper interface #327

Closed
AlekSi opened this issue Sep 3, 2018 · 1 comment
Closed

Add minimal MySQL version to Scraper interface #327

AlekSi opened this issue Sep 3, 2018 · 1 comment

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Sep 3, 2018

@arvenil's PR #265 introduced Scraper interface. Now we propose to expand it to include the following method:

type Scraper interface {
	// Version of MySQL from which scraper is available.
	Version() float64
}

It then can be used to skip unsupported versions entirely:

	for _, scraper := range e.scrapers {
		if versionNum < scraper.Version() {
			continue
		}

I can work on porting this feature from Percona's fork if you are interested.

@SuperQ
Copy link
Member

SuperQ commented Sep 3, 2018

Oh, that sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants