Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nhcb: add global and scrape level convert_classic_histograms option #13532

Open
Tracked by #13485
krajorama opened this issue Feb 2, 2024 · 1 comment
Open
Tracked by #13485

Comments

@krajorama
Copy link
Member

krajorama commented Feb 2, 2024

Proposal

Depends on #13486 #13487 #13529 at least :)

The configuration option should enable conversion upon scrape.
Documentation is also included in this task.

Configuration and expected outcome

In all cases the native histograms feature is enabled. When the feature is disabled, there are no native histograms, so classic histograms have to be produced by the scrape.

Case 1. Metric instrumentation only exposes classic histograms

Typical legacy application scenario.

config classic float series exponential nh custom bucket nh
scrape_classic=false, convert_classic=false
scrape_classic=true, convert_classic=false
scrape_classic=false, convert_classic=true
scrape_classic=true, convert_classic=true

Case 2. Metric instrumentation exposes both classic and exponential native histograms

Exponential native histogram has more information, preferred over custom buckets. Note: we must make a choice since both custom bucket and exponential histogram has the same metric name.

config classic float series exponential nh custom bucket nh
scrape_classic=false, convert_classic=false
scrape_classic=true, convert_classic=false
scrape_classic=false, convert_classic=true
scrape_classic=true, convert_classic=true

Case 3. Metric instrumentation only exposes exponential native histograms

No classic histogram to expose or convert.

config classic float series exponential nh custom bucket nh
scrape_classic=false, convert_classic=false
scrape_classic=true, convert_classic=false
scrape_classic=false, convert_classic=true
scrape_classic=true, convert_classic=true
@kushalShukla-web
Copy link
Contributor

like to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants