The golangcilint linter of perfsprint is not working as expected

[gotjosh]

What did you do?

I noticed that this particular line should have been caught by the linter and failed: https://github.com/prometheus/prometheus/blob/main/rules/manager_test.go#L198 (there are more examples)

[gotjosh]

It seems like with the upgrade of golangcilint some of the linter don't work (or work?) as expected. You can see an example of it here: #14215

@aknuds1 should we rollback #14153 until we figure it out?

[aknuds1]

Why does a performance linter matter for test files?

[gotjosh]

Why does a performance linter matter for test files?

It doesn't - but it's not the way it worked in the previous version thus can be considered a breaking change?

[gotjosh]

When perfsprint was originally introduced it linted all of the test files too: #14091 - with the upgrade of golangcilint it stopped.

So at the very minimum, it is now inconsistent.

[aknuds1]

I noticed that this particular line should have been caught by the linter and failed: https://github.com/prometheus/prometheus/blob/main/rules/manager_test.go#L198

It's not a regression. That line is not caught because of a perfsprint exclusion in .golangci.yml. That exclusion had to be updated for v1.59.0. That's why you see more things getting caught when downgrading.

[gotjosh]

🤦 so this is actually text-based exclusion in golangcilint TIL.

This comment from Björn makes all the sense in the world: #14091 (comment)

[gotjosh]

Thanks for the clarification 😉