Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtool check metrics does not validate uniqueness #5242

Open
carlpett opened this Issue Feb 20, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@carlpett
Copy link

carlpett commented Feb 20, 2019

Bug Report

What did you do?
curl -s ... | promtool check metrics

What did you expect to see?
According to the specs:

Each line must have a unique combination of a metric name and labels. Otherwise, the ingestion behavior is undefined.

We had an endpoint that served duplicates for some name/label sets, but promtool does not complain.

What did you see instead? Under which circumstances?
Nothing

Environment
promtool from master/c8a1a5a9

An independent repro without our faulty exporter is

# HELP foo testing
# TYPE counter
foo{bar="1"} 1
foo{bar="1"} 2
EOF
  • System information:
    Darwin 18.2.0 x86_64

  • Prometheus version:
    git c8a1a5a

@geekodour

This comment has been minimized.

Copy link
Contributor

geekodour commented Mar 1, 2019

will send the fix if I can reproduce the issue on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.