Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fortytw2/leaktest to all unit tests that involves go routines. #6925

Closed
bwplotka opened this issue Mar 4, 2020 · 1 comment · Fixed by #7566
Closed

Add fortytw2/leaktest to all unit tests that involves go routines. #6925

bwplotka opened this issue Mar 4, 2020 · 1 comment · Fixed by #7566

Comments

@bwplotka
Copy link
Member

bwplotka commented Mar 4, 2020

Hi, 👋

We found this super useful in the Thanos project, it allows us to find memory leaks in the form of not closed go routines pretty fast. Thanks for @gotjosh who reminds me to put a request for that. 🤗

Help wanted!

NOTE1: It does not work with t.Parallel until this: fortytw2/leaktest#4
NOTE2: At some point, Uber created its own lib which does the same (without even trying to contribute to the existing https://github.com/fortytw2/leaktest) here: https://github.com/uber-go/goleak Since https://github.com/fortytw2/leaktest works well, is mature and have friendly maintainers, I would say let's stick to that. (:

@liguozhong
Copy link
Contributor

liguozhong commented Mar 4, 2020

good idea!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants