Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MetricPersistence interface to query values by fingerprint instead of by metric #77

Closed
juliusv opened this issue Feb 14, 2013 · 2 comments
Closed

Change MetricPersistence interface to query values by fingerprint instead of by metric #77

juliusv opened this issue Feb 14, 2013 · 2 comments

Comments

@juliusv
Copy link
Member

juliusv commented Feb 14, 2013

It might make sense to change the interface of e.g. GetValueAtTime(), GetBoundaryValues(), and GetRangeValues() to expect a fingerprint instead of a metric labelset.

The AST currently starts off knowing a labelset, then gets all fingerprints for that, then gets the metrics for those fingerprints, then gets the values for each of those metrics.

It could be just: get all fingerprints for labelset, fetch values for each fingerprint. One conversion step less.
@matttproud
Copy link
Member

Fixed by @juliusv.

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017
@fabxc
Merge pull request prometheus#77 from stapelberg/patch-1
bb53c6b 
Fix rule_checker example
@lock
Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matttproud @juliusv