This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Select series with label unset for != and !~ #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabxc
reviewed
Dec 18, 2017
| @@ -289,7 +289,7 @@ func (pb *Block) Delete(mint, maxt int64, ms ...labels.Matcher) error { | |||
| return ErrClosing | |||
| } | |||
|
|
|||
| p, absent, err := PostingsForMatchers(pb.indexr, ms...) | |||
db_test.go
Outdated
| testutil.Ok(t, err) | ||
| defer db.Close() | ||
|
|
||
| lbls := labels.Labels{labels.Label{Name: "labelname", Value: "labelvalue"}} |
There was a problem hiding this comment.
labels.FromStrings("labelname", "labelvalue") – those helpers were mostly added for tests.
db_test.go
Outdated
| defer q.Close() | ||
|
|
||
| ss, err := q.Select(labels.Not(labels.NewEqualMatcher("lname", "lvalue"))) | ||
| testutil.Ok(t, err) |
There was a problem hiding this comment.
Probably cheap and easy to add a few other checks here as well.
Fixes prometheus/prometheus#3575 Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in> Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
not-matchers
branch
from
33fd60c
to
3158b03
Compare
|
Fixed all comments but did not run any benchmarks. Will do them later, sorry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/prometheus#3575
Signed-off-by: Goutham Veeramachaneni cs14btech11014@iith.ac.in
This change is