Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite passes even if clause 2.3.2 is not implemented #71

Closed
abdulapopoola opened this issue Feb 8, 2015 · 1 comment
Closed

Test suite passes even if clause 2.3.2 is not implemented #71

abdulapopoola opened this issue Feb 8, 2015 · 1 comment

Comments

@abdulapopoola
Copy link

I removed the entire implementation of 2.3.2 from my promise implementation (adehunJS) and still got the full suite to pass.

Is this a test hole? Wrong implementations can also cause the test suite to pass.

@abdulapopoola abdulapopoola changed the title Test passes even if clause 2.3.2 is not implemented Test suite passes even if clause 2.3.2 is not implemented Feb 8, 2015
@domenic
Copy link
Member

domenic commented Jul 15, 2015

2.3.2 is actually redundant with 2.3.3, in the sense that implementing 2.3.3 will also implement 2.3.2. (But, implementing 2.3.2 does not imply implementing 2.3.3.) The reason it exists is that we want to allow people to go down different paths for known-promises vs. other thenables.

So, this is entirely as expected. If we removed 2.3.2, then we would add some tests ensuring that even known-promises go down the promise resolution procedure path. So it's more about governing what tests are not there, than about adding tests for it.

@domenic domenic closed this as completed Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants