Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/shutdown after download closing after one download #145

Conversation

CometDog
Copy link
Contributor

  • TorrentTaskService will now verify that all torrent downloads are out of the DOWNLOADING state before attempting to shut down the app
  • Added the FLAG_ACTIVITY_CLEAR_TOP flag to the intent to launch MainActivity from AddTorrentActivity
    • The behavior without this causes multiple layers of MainActivity to be created, meaning the app won't fully shut down at shut down, it'll just close the top layer. This change fixes that behavior

… AddTorrentActivity to prevent multiple layers of MainActivity from being created
@proninyaroslav
Copy link
Owner

Thanks. I don't know why checking downloaded torrents has disappeared.

@proninyaroslav proninyaroslav merged commit 234dffd into proninyaroslav:master Dec 21, 2017
@CometDog
Copy link
Contributor Author

It is possible that this seemed to be functional due to the other bug I fixed. Since AddTorrentActivity was creating a new layer of MainActivity every time you added a torrent, after each download finished, only layer would be stripped off. So you had 8 torrents, and 8 layers of MainActivity. After each one, a layer gets removed until the app actually shuts down and closes.

@CometDog CometDog deleted the bugfix/shutdown-after-download-closing-after-one-download branch December 21, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants