Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTR: Game End Signal #314

Closed
proof88 opened this issue Apr 9, 2024 · 1 comment
Closed

FTR: Game End Signal #314

proof88 opened this issue Apr 9, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@proof88
Copy link
Owner

proof88 commented Apr 9, 2024

Currently only a hard coded frag limit ends the game which is monitored constantly on client side as well!
This is no good for server-configured frag limit and/or time limit so we need to introduce a new server -> clients message type to explicitly signal end of game, this way clients wont need to monitor this at all.

Update: note that since v0.2.3 clients receive server config so they could still properly detect game end even if frag limit is not hardcoded. However, with server-configured time limit, it would be more difficult to properly detect game end for clients, so I think it is better if we explicitly introduce this new message type.
Also, from theory point of view, the proper way of syncing clients with server is adding this new message. Otherwise we are just suspecting that clients really detect game end at the same time as server does.
Also in the future other more sophisticated game end goals might be introduced, overall it is better if only server is managing that since server is the single source of truth.

@proof88 proof88 added the enhancement New feature or request label Apr 9, 2024
@proof88 proof88 added this to the Gameplay (Public Beta) milestone Apr 9, 2024
@proof88
Copy link
Owner Author

proof88 commented May 13, 2024

Done for v0.2.4.

@proof88 proof88 closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant