Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP API UserCredentials #55

Closed
enumag opened this issue Dec 6, 2018 · 1 comment
Closed

HTTP API UserCredentials #55

enumag opened this issue Dec 6, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@enumag
Copy link
Member

enumag commented Dec 6, 2018

I don't like passing the UserCredentials object to each method that uses the HTTP API (such as SyncProjectionsManager or SyncPersistentSubscriptionsManager). Maybe we could pass a default UserCredentials to constructor and use it as fallback?

I can prepare a PR for this if you want. If you don't want this feature then just close this issue.
@prolic
Copy link
Member

prolic commented Dec 6, 2018 •
edited

Yes, I'm okay with that. Implementation can be the same as in EventStoreAsyncNodeConnection.

@prolic prolic added the enhancement New feature or request label Dec 29, 2018
@prolic prolic closed this as completed in 0d4d18d Dec 30, 2018
@enumag enumag mentioned this issue Sep 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prolic @enumag