Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectionManagerFactory doesn't handle EventStoreDecorator #55

Closed
camilledejoye opened this issue Dec 31, 2018 · 1 comment
Closed

Comments

@camilledejoye
Copy link

camilledejoye commented Dec 31, 2018

Hi there,

First of all, thanks for the work done!

It appears that the ProjectionManagerFactory hard code the types of allowed EventStore.
My problem was that I'm using a TransactionalActionEventEmitterEventStore, to be specific :)

So when I tried to configure a projection manager to use this store, if failed.
Indeed this store doesn't implement any of the providing PDO implementation of the event store.

You ask to open an issue before make any PR, so here I am.

The PR is ready anyway, I will push it to my fork onto a new branch with this issue number.

There is the link to the proposed solution

@codeliner
Copy link
Member

@elythyr thx! The proposed solution looks good! PR would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants