Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI and pull requests #122

Closed
vincenthage opened this issue Jun 16, 2017 · 7 comments
Closed

Travis CI and pull requests #122

vincenthage opened this issue Jun 16, 2017 · 7 comments
Assignees
Projects

Comments

@vincenthage
Copy link
Contributor

vincenthage commented Jun 16, 2017

Hi,
Travis CI has been renabled on this repos;
it should make PR-merging easier, as it looks like most of them are frozen.
And by that I mean PRs that are probably working and only missing throughout testing on multiple environments.

So now when introducing a new feature or a bug fix, we should also add a test along it
(or is-it too much and it would slow down PR merging even more?).

Any commit/merge on master, and update on pull requests will trigger a run,
but the existing pull requests won't be run until they are updated in some way
so we will have to manually update them (either with a commit or by closing/opening them).

If you have any comment about the current state of PRoot and how to improve it,
don't mind leaving a message here.

Cheers,
Vincent

@jopasserat
Copy link
Member

Maybe we should specify / clarify a branching policy as well?
It seems there are some new features in next.
Do you think all PRs should be done against next and then next would be merged into master upon release?

@vincenthage
Copy link
Contributor Author

That's a good idea, and it will allow us to populate the changelog in batches.
Though next is bit behind at the moment and needs to be updated:
image

@ghost
Copy link

ghost commented May 3, 2018

Ideally, travis-ci should build new releases automatically. That would take care of #127

@oxr463 oxr463 self-assigned this Nov 8, 2018
@oxr463
Copy link
Collaborator

oxr463 commented Nov 8, 2018

  • Update .travis.yml
  • Update README.md to point to appropriate URLS
  • Fix failing test (CHECK test-230f47cf FAILED)

oxr463 added a commit that referenced this issue Nov 8, 2018
oxr463 added a commit that referenced this issue Nov 8, 2018
@oxr463
Copy link
Collaborator

oxr463 commented Nov 8, 2018

@vincenthage, it looks like you already applied those fixes in the travis branch. Where you able to fix Coverity? It looks like it is still pointing to the old URL.

@oxr463 oxr463 added this to High priority in Triage Nov 9, 2018
oxr463 added a commit that referenced this issue Dec 11, 2018
* Update Coverity Settings to current project URL
* Update status badges for ci
* Update README.rst

Bugs: #122
oxr463 added a commit that referenced this issue Dec 11, 2018
* Update Coverity Settings to current project URL
* Update status badges for ci
* Update README.rst

Bugs: #122
@oxr463
Copy link
Collaborator

oxr463 commented Dec 12, 2018

@oxr463
Copy link
Collaborator

oxr463 commented Dec 13, 2018

So now when introducing a new feature or a bug fix, we should also add a test along it
(or is-it too much and it would slow down PR merging even more?).

As a new contributor, I am finding a hard time figuring out what the tests actually do; the names aren't very descriptive. Perhaps we should include a comment in each test summarizing what the test does?

@oxr463 oxr463 pinned this issue Jan 8, 2019
@oxr463 oxr463 unpinned this issue Mar 4, 2019
@oxr463 oxr463 added the meta label Mar 11, 2019
oxr463 added a commit that referenced this issue Apr 1, 2019
This test started failing on ca57ca5.

Bug: #122
Bug: #164
@oxr463 oxr463 closed this as completed in b38a767 Apr 1, 2019
Triage automation moved this from High priority to Closed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Triage
Closed
Development

No branches or pull requests

3 participants