Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of Copy-On-Write #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alejandroliu
Copy link

Implements Copy-On-Write semantics as an Extension to PRoot. It is supposed to be similar to
cowdancer which doesn't work inside
a proot jail.

This is a naive implementation, intended to get a working version quickly.

@vincenthage
Copy link
Contributor

Hi Alejandro,
Great job!

Would you mind adding a test that uses your extension so that it can be fully tested?

@alejandroliu
Copy link
Author

I wouldn't mind, but I don't know how the test framework from PRoot works. I see files in the test directory, and I only see a bunch of files with test-XXXXX (which looks quite random to me).

If you can point me to an specific example on how to plug in my test, I would be happy to write one.

* upstream/master:
  Use LC_ALL instead of LANG
  fix: update URLs to proot-me.github.io
  add: gitignore
  Fix use of size
@coveralls
Copy link

coveralls commented Jun 18, 2017

Coverage Status

Changes Unknown when pulling 5342c87 on TortugaLabs:cow into ** on proot-me:master**.

@vincenthage
Copy link
Contributor

vincenthage commented Jun 18, 2017

The travis logs give some commands to execute the tests:
https://travis-ci.org/proot-me/PRoot/jobs/244300611
https://travis-ci.org/proot-me/PRoot/builds/243781511
and it shows that there is an issue the tests on the PR btw:
/home/travis/.travis/job_stages: line 54: [: !=: unary operator expected

I'm also in the process of trying to understand how the tests are done;
from what I see, the tests are listed in the GNUmakefile,

@vincenthage
Copy link
Contributor

vincenthage commented Jun 18, 2017

As an example,
you can check out @guillon 's test which also involves a new option:
https://github.com/proot-me/PRoot/pull/97/files#diff-968b794e2f95eb8152dcce887f40d455

@vincenthage vincenthage mentioned this pull request Jul 8, 2017
@oxr463 oxr463 added this to Low priority in Triage Nov 9, 2018
@oxr463 oxr463 added this to the PRoot v5.1.1 milestone Nov 29, 2018
@oxr463 oxr463 added this to In progress in PRoot via automation Nov 29, 2018
@oxr463 oxr463 modified the milestones: PRoot v5.2, PRoot Next Aug 29, 2021
@oxr463 oxr463 self-assigned this Sep 7, 2021
@oxr463 oxr463 removed this from the PRoot Next milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PRoot
In progress
Triage
Low priority
Development

Successfully merging this pull request may close these issues.

None yet

4 participants