Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on the timeZone support #119

Open
ykdojo opened this issue Sep 15, 2023 · 2 comments · May be fixed by #120
Open

Add documentation on the timeZone support #119

ykdojo opened this issue Sep 15, 2023 · 2 comments · May be fixed by #120
Labels
documentation Improvements or additions to documentation

Comments

@ykdojo
Copy link
Contributor

ykdojo commented Sep 15, 2023 •
edited
Loading

Even though we added a timeZone support here (#110), we don't have documentation on this feature yet.

We should make sure that it's documented for Counter, TimeSeries and Leaderboard. For example on this page (https://github.com/propeldata/ui-kit/blob/main/packages/ui-kit/src/components/TimeSeries/README.md) for TimeZone.

Closes PRO-2314 (this is an internal ticket ID).
@CBID2
Copy link

CBID2 commented Sep 15, 2023

I’ll try it :)

@CBID2 CBID2 linked a pull request Sep 17, 2023 that will close this issue
Draft
4 tasks
@CBID2
Copy link

CBID2 commented Sep 17, 2023

Even though we added a timeZone support here (#110), we don't have documentation on this feature yet.

We should make sure that it's documented for Counter, TimeSeries and Leaderboard. For example on this page (https://github.com/propeldata/ui-kit/blob/main/packages/ui-kit/src/components/TimeSeries/README.md) for TimeZone.

Closes PRO-2314 (this is an internal ticket ID).

Hi @ykdojo! I started a draft PR on the documentation. Its #120

@sashathor sashathor added the documentation Improvements or additions to documentation label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add documentation about timezone feature CBID2/ui-kit
3 participants
@ykdojo @sashathor @CBID2