Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fury accepts module parameters that aren't supported by the selected module kind #1491

Open
odisseus opened this issue Aug 2, 2020 · 1 comment
Assignees
Labels
bug Something isn't working user interface Relates to the front-end user interface

Comments

@odisseus
Copy link
Collaborator

odisseus commented Aug 2, 2020

Steps to reproduce

% fury module update -m test -t lib --timeout 10

Expected behaviour: an error message is displayed; the layer is not updated.
Actual behaviour: the layer is successfully updated; the timeout is set to 0.

This bug is present in the current master version, and the new command API doesn't provide an obvious way to fix it.

Additional information:

$ diff <(ipfs cat QmcVoV7jrpzN6MkkH5PY5kR5dLjgZK4ric2c85VFZCMZEV) <(ipfs cat QmWaotk1zN2enrzA7CuqfVdoyptmVkLGbatvMN9kZ2VJfh)
105,107c105
< 			test	kind	App	main	fury.test.AllTests
< 						timeout	0
< 				compiler	BspCompiler	id	scala/compiler
---
> 			test	compiler	BspCompiler	id	scala/compiler
171c169
< previous	Some	Qma53uahjNCCoiyYhCg17HkifQQTdpfCBQCz94rqEBZ3uz
---
> previous	Some	QmcVoV7jrpzN6MkkH5PY5kR5dLjgZK4ric2c85VFZCMZEV
$ fury module list -m test
//Waotk1zN#fury
╔══╤════════╤══════════════╤══════════════╤══════════╤════════════════╤═════════╤══════╗
║  │ Module │ Dependencies │ Sources      │ Binaries │ Compiler       │ Options │ Type ║
╠══╪════════╪══════════════╪══════════════╪══════════╪════════════════╪═════════╪══════╣
║  │ test   │ io-test      │ src/test//** │ 0        │ scala/compiler │ 0       │ lib  ║
║  │        │ core-test    │              │          │                │         │      ║
║  │        │ model-test   │              │          │                │         │      ║
║  │        │ text-test    │              │          │                │         │      ║
║  │        │ ogdl-test    │              │          │                │         │      ║
╚══╧════════╧══════════════╧══════════════╧══════════╧════════════════╧═════════╧══════╝

@odisseus odisseus self-assigned this Aug 2, 2020
@odisseus odisseus added bug Something isn't working user interface Relates to the front-end user interface labels Aug 2, 2020
@propensive
Copy link
Owner

In general, we should "consume" parameters when we extract them, and then we should check at the end whether there are any unexpected parameters remaining. Let's not worry about it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user interface Relates to the front-end user interface
Projects
None yet
Development

No branches or pull requests

2 participants