Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate performance issue with updating the hierarchy #1500

Open
propensive opened this issue Aug 5, 2020 · 1 comment
Open

investigate performance issue with updating the hierarchy #1500

propensive opened this issue Aug 5, 2020 · 1 comment
Assignees
Labels
performance Relates to performance characteristics
Projects
Milestone

Comments

@propensive
Copy link
Owner

This is apparent, for example, when updating a layer using the new export menu. It appears like IPFS is called many times, possibly once for every layer in the tree.

This may be fixed by not using Layer.store so often, or by adding caching to Layer.store, but the latter may result in a memory leak if Layers are used as keys for a hash map.

@propensive propensive added the performance Relates to performance characteristics label Aug 5, 2020
@propensive propensive added this to scoped in release via automation Aug 5, 2020
@propensive propensive added this to the Alecto milestone Aug 5, 2020
@odisseus
Copy link
Collaborator

odisseus commented Aug 6, 2020

It turns out that the layers with their IPFS references are already cached in memory since PR #1173. However, the logs still show a lot of repeating messages "Checking for IPFS daemon".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Relates to performance characteristics
Projects
release
  
scoped
Development

No branches or pull requests

2 participants