Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement assert macro #41

Closed
propensive opened this issue Dec 24, 2021 · 0 comments
Closed

Reimplement assert macro #41

propensive opened this issue Dec 24, 2021 · 0 comments
Assignees
@propensive
Labels
api Relates to the API design enhancement An improvement to existing functionality severe Has a significant impact on many users

Comments

@propensive
Copy link
Owner

The assert macro's implementation requires it to attempt to pattern match on equality predicates. But equality predicates involving primitive types seem to have different AST representations so that a single case can't match all of them, and in the code, the pattern is duplicated dozens of times. This code is ugly, and difficult to maintain.
@propensive propensive self-assigned this Dec 24, 2021
@propensive propensive changed the title Implementation of the assert macro is difficult to maintain Reimplement assert macro Dec 28, 2022
@propensive propensive mentioned this issue Dec 28, 2022
Closed
@propensive propensive added severe Has a significant impact on many users api Relates to the API design enhancement An improvement to existing functionality labels Jan 2, 2023
@propensive propensive added this to the Primevère milestone Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@propensive propensive

Labels
api Relates to the API design enhancement An improvement to existing functionality severe Has a significant impact on many users
Projects
Soundness
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@propensive