Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after pull it doesn't compile #24

Closed
fisher opened this issue Feb 13, 2012 · 7 comments
Closed

after pull it doesn't compile #24

fisher opened this issue Feb 13, 2012 · 7 comments

Comments

@fisher
Copy link

fisher commented Feb 13, 2012

==> proper (compile)
include/proper_internal.hrl:26: can't find include file "compile_flags.hrl"

@kostis
Copy link
Collaborator

kostis commented Feb 13, 2012

I am afraid I cannot reproduce what you are reporting. Is it possible that you need to do a 'make distclean' first? Do you have a compile_flags.hrl file in the include dir? (This file could actually be empty, depending on the OTP version you are using.)

@fisher
Copy link
Author

fisher commented Feb 15, 2012

I'm sorry, but bug still in there. It can't be reproduced when compiled as a standalone application. Instead, try to compile it as 'dependency' application usin 'rebar' tool:

==> vsports (get-deps)
[...]
Pulling proper from {git,"https://github.com/manopapad/proper.git","master"}
Cloning into 'proper'...
[...]
==> proper (compile)
src/strip_types.erl:50: Warning: missing specification for function parse_transform/2
Compiled src/strip_types.erl
include/proper_internal.hrl:26: can't find include file "compile_flags.hrl"
make: *** [all] Error 1

The file compile_flags.hrl didn't created, find (1) didn't found it. I think this is because you try to execute 'write_compile_flags' script in current directory, when, in fact, the current directory is for upper level application and proper located in 'deps/proper' directory.

@kostis
Copy link
Collaborator

kostis commented Feb 15, 2012

I see. However, I am not convinced that this is a problem in PropEr instead of your rebar use or your directory structure.
For example, due to issues 23, 25 and 26 , I know for a fact that there are various projects that use PropEr as a dependency and do not have the problem that you reported (this is because they found other problems, which by now are solved). You may want to look at the code bases of the developers that reported the issues and get some inspiration on how to add PropEr as a dependency in your code base.

In any case, if you do not manage to fix the problem in the way I suggested, we'll gladly consider to include in PropEr's code base a pull request that fixes the problem.

@kostis
Copy link
Collaborator

kostis commented Apr 4, 2012

Is this issue fixed by now or you still have problems? If you have managed to solve it somehow we would be interested in finding out how this was done and possibly incorporate your fix into PropEr.

@kostis kostis closed this as completed May 4, 2012
@kostis kostis reopened this May 4, 2012
@kostis
Copy link
Collaborator

kostis commented May 4, 2012

Since a month has passed and there have been no replies from the person staring this thread, I am closing it. Open a new issue if there are still problems.

@kostis kostis closed this as completed May 4, 2012
@JonGretar
Copy link

For those who end up here after google search of this error. It's caused by having too old version of rebar installed. Just upgrade rebar and you will be fine.

@jstasiak
Copy link

I had the same issue and your note helped solving it. Thank you @JonGretar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants