Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test more backends and handle resizing for interactive backends #62

Closed
lukelbd opened this issue Nov 6, 2019 · 4 comments
Closed

Test more backends and handle resizing for interactive backends #62

lukelbd opened this issue Nov 6, 2019 · 4 comments

Comments

@lukelbd
Copy link
Collaborator

lukelbd commented Nov 6, 2019

When either of the width or height dimensions are not passed to the figure, the proplot tight layout algorithm resizes the figure. This means whenever the figure has to be "re-drawn", as with expanding a popup window, the algorithm will try to snap the window back to match the old figure size, resulting in weird/jumpy behavior.

Had two ideas to fix this.

  1. Make all backend window sizes explicitly locked. See this thread for ideas.
  2. Have set_size_inches update the underlying geometry_configurator settings (see Replace "panels" with EdgeStack, permit working directly with add_subplot/GridSpec #50) so that "width" and "height" are both fixed, and also make the axwidth, axheight, and aspect settings modifiable (also rename aspect to axaspect?). Internal calls to set_size_inches can pass a keyword arg like lock=False that prevents updating geometry settings.

Leaning towards 2. Also, while I'm at it, I can also do a more rigorous test of how automatic figure resizing interacts with the various backends.

@lukelbd lukelbd changed the title Test more backends and lock window resizing for popup / interactive inline backends Test more backends and handle resizing for popup / interactive inline backends Nov 6, 2019
@lukelbd lukelbd changed the title Test more backends and handle resizing for popup / interactive inline backends Test more backends and handle resizing for interactive backends Nov 6, 2019
@lukelbd lukelbd added the bug label Nov 30, 2019
@lukelbd
Copy link
Collaborator Author

lukelbd commented Nov 30, 2019

Some backends also have a problem with the automatic offset of row/column labels and "super" titles. Thought I fixed this before but evidently not. See this example:

Screen Shot 2019-11-29 at 10 15 40 PM

@lukelbd
Copy link
Collaborator Author

lukelbd commented Dec 1, 2019

This needs to be higher priority. It's currently causing bugs when nbsphinx executes the cells from the documentation notebooks on RTD. Trying for a workaround.

@lukelbd
Copy link
Collaborator Author

lukelbd commented Dec 1, 2019

#46 (#50) will probably fix this. Super titles and row/column labels will be implemented with the same API used to draw outer colorbars and legends.

@lukelbd lukelbd added this to the Version 1 milestone Dec 2, 2019
@lukelbd
Copy link
Collaborator Author

lukelbd commented Dec 2, 2019

Ended up fixing the tight layout bug and making the algorithm more robust to different backends for v0.1.3 (commit: 67221d1). But manual resizing with interactive backends is still an issue -- see #76 for further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant