Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding setters and getters associated with all Axes.format features #63

Closed
lukelbd opened this issue Nov 10, 2019 · 1 comment

Comments

@lukelbd
Copy link
Collaborator

lukelbd commented Nov 10, 2019

For consistency with the matplotlib API, all of the features implemented in self.format() should be implemented with setters and getters, then the axes can be updated with native Artist.update or Artist.set methods. Also, Axes.format will redirect to update and issue a deprecation warning.

Here is some background:

  • The matplotlib API uses setters and getters for updating arbitrary abstract Artist classes, including the Axes class.
  • The matplotlib API also has Artist.set and Artist.update methods for bulk updating arbitrary artists. Example usage: If an artist has set_linewidth and set_linestyle methods, then update and set will accept linewidth and linestyle as keyword args and pass them to the setter.
  • Part of the inspiration for ProPlot was that I found line-by-line property setting to be very inefficient in day-to-day usage, and wanted one function for updating all aspects of the axes. The problems with Artist.update and Artist.set are:
    (1) almost on one uses them (especially with Axes artists), (2) they appear seldom in the examples, and (3) there is no artist-specific documentation on keyword arguments accepted by these methods, since they work by searching for arbtirary setters with getattr(self, 'set_' + key), so only advanced users will learn how to use them.

I think it is important for users to be able to modify arbitrary properties of python classes in place without a "bulk" function. However, it is also important for the sake of efficiency that users have this "bulk" function, and they should be encouraged to use the "bulk" one in the first place.

Where ProPlot can improve this is by documenting the "bulk" function by scanning the Axes attributes and building a numpydoc-style parameter table from the first line of every setter, and allowing people to pass keyword args to arbitrary setters with {setting}_kw-style arguments. Every ProPlot example will still use the bulk updater to encourage this for new users.

A more bold option could be to monkey patch the matplotlib Artist class, overriding its set and update methods so that every artist is documented like this. But I think the PR will just start with axes.

@lukelbd lukelbd changed the title Add setters and getters associated with all "format" features Add setters and getters associated with all Axes.format features Nov 10, 2019
@lukelbd lukelbd changed the title Add setters and getters associated with all Axes.format features Consider adding setters and getters associated with all Axes.format features Nov 16, 2019
@lukelbd lukelbd added this to the Version 1 milestone Nov 28, 2019
@lukelbd
Copy link
Collaborator Author

lukelbd commented Aug 22, 2021

Individual setters are no longer a goal of mine beyond a few very specific cases of proplot-specific features. See the discussion in #89.

@lukelbd lukelbd closed this as completed Aug 22, 2021
@lukelbd lukelbd removed this from the Version 0.9 milestone Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant