-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a quickcheck interoperability layer #18
Comments
I would prefer a separate crate. Besides the benefits you mentioned, it also makes it clearer (e.g., for someone looking at it on crates.io) that it's an add-on should one find the use for it rather than a significant-but-optional core feature. |
A new crate coming your way in a bit =) |
(Perhaps we should organize stuff into a GitHub organization soon to have repositories in the same place-ish?) |
The promised crate: https://github.com/Centril/proptest-quickcheck-interop . |
The crate looks reasonable to me. Only one comment: https://github.com/Centril/proptest-quickcheck-interop/blob/master/src/lib.rs#L332 Could that
Certainly. |
Oh! Why didn't I think of that... ;) Fixed in 1.04. |
The docs now link to this crate in the paragraph after the introduction. |
I've created an interoperability layer between proptest and quickcheck, should I add this to proptest as a PR under a feature flag
quickcheck
or do you believe this belongs in a separate crate?The benefit of the latter is that proptest is not then constrained in dependencies by
quickcheck
while the benefit of the former is that the user doesn't have to write in another dependency to their project.What it amounts to is essentially (details omitted):
The text was updated successfully, but these errors were encountered: